also we need general linting and formatting like last time :)

Thanks. I added a pre-commit dependency and defined formatting and type check as the steps in the pre-commit. I'd love to show you but I currently can't commit because it is failing type checks lol. But let me know if you think if it's a good idea, once you get back to me on the closed parameter issue, and I push the changes.

i've seen some integrated CIs running in GitHub actions that gets auto run and tagged onto the commit/PR. that issue you're dealing with is the exact reason i'd be hesitant to add a pre-commit hook

Hi James, please have a look at the pre-commit yaml file, let me know if you think the steps are okay to include.

it looks like exactly what we should run as pre-commit, check out the checks i added for #7. i'll merge these pre-commit changes along with that.

i'll just need you to 1. create a new branch with only the pre-commit changes, 2. amend the pre-commit changes off of this commit, and then i can incorporate that commit into #7.

Done. The branch I created is called: add-pre-commit-steps, but it only has pre-commit and github CI actions. Let me know if I misunderstood you.

thanks! that's all, it's merged now